[JULES] Scheduled Maintenance: Pattern Value Refactor by logbie · Pull Request #504 · WebFirstLanguage/wfl

logbie · 2026-05-15T09:35:41Z

Summary of Changes

The Issue: Manual match blocks were being used repeatedly across src/stdlib/pattern.rs to extract Value::Text and Value::Pattern from function arguments, duplicating error handling and extraction logic.
The Rational: Improved maintainability, eliminated redundancy, and standardized error messaging.
The Solution: Added a new macro-generated expect_pattern to src/stdlib/helpers.rs and refactored multiple functions in src/stdlib/pattern.rs (pattern_matches_native, pattern_find_native, pattern_find_all_native, native_pattern_replace, native_pattern_split) to use the expect_text and expect_pattern helpers instead of manual pattern matching.

Verification Checklist

cargo fmt executed and passed.
cargo clippy returned no warnings or errors.
All cargo test suites passed (100% success rate).

PR created automatically by Jules for task 17883455864191053605 started by @logbie

Summary by CodeRabbit

Refactor
- Consolidated pattern validation logic and improved error messages across pattern-related operations, including matching, finding, replacement, and splitting functions.
Tests
- Updated test assertions to verify more specific and descriptive error messages when pattern functions receive incorrect argument types.

Co-authored-by: logbie <1138960+logbie@users.noreply.github.com>

google-labs-jules · 2026-05-15T09:35:42Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-05-15T09:35:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8a82919-4c77-459b-920d-878b7442e54e

📥 Commits

Reviewing files that changed from the base of the PR and between 68d08ee and e45023c.

📒 Files selected for processing (3)

src/stdlib/helpers.rs
src/stdlib/pattern.rs
src/stdlib/pattern_test.rs

📝 Walkthrough

Walkthrough

This PR introduces a new expect_pattern helper extractor and refactors five pattern native functions and their tests to standardize argument validation. Manual Value destructuring and custom error reporting are replaced with reusable expect_text and expect_pattern helpers, producing more consistent error messages.

Changes

Pattern helper and native function consolidation

Layer / File(s)	Summary
New expect_pattern extractor `src/stdlib/helpers.rs`	Added `expect_pattern` function that validates a Value is a Pattern variant, returning `Rc<CompiledPattern>` on success or `RuntimeError` with type mismatch details on failure.
Refactor pattern native functions to use helpers `src/stdlib/pattern.rs`	`pattern_matches_native`, `pattern_find_native`, `pattern_find_all_native`, `native_pattern_replace`, and `native_pattern_split` now extract `text` and `pattern` arguments via shared `expect_text` and `expect_pattern` helpers, replacing manual `Value` pattern matching. Result shapes remain unchanged.
Update test assertion for refactored error messages `src/stdlib/pattern_test.rs`	`test_pattern_matches_native_wrong_first_arg_type` now validates the specific error substring `"Expected text, got Number"` produced by the standardized helper extraction.

Possibly related PRs

WebFirstLanguage/wfl#310: Extends src/stdlib/helpers.rs with expect_pattern and refactors pattern functions to use shared expect_text/expect_pattern extractors.
WebFirstLanguage/wfl#427: Adds and standardizes typed expect_* extractors in src/stdlib/helpers.rs through macro generation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A pattern extracts what it seeks,
No more handwritten error-speak,
Type-checking helpers stand in line,
Each native function now feels fine,
Consistent checks, no mess, no strife! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: a refactoring of pattern value extraction logic to use helper functions instead of manual matching.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch maintenance-refactor-pattern-expect-17883455864191053605

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR refactors pattern stdlib argument extraction to use shared helper functions, reducing duplicated Value::Text/Value::Pattern matching and standardizing type error messages.

Changes:

Adds a macro-generated expect_pattern helper for extracting Value::Pattern.
Refactors pattern matching/find/replace/split natives to use expect_text and expect_pattern.
Updates the affected pattern test expectation for the standardized text type error.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`src/stdlib/helpers.rs`	Adds the reusable `expect_pattern` extraction helper.
`src/stdlib/pattern.rs`	Replaces repeated manual argument type matching with helper calls.
`src/stdlib/pattern_test.rs`	Updates the wrong-argument-type assertion to match standardized helper output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Refactor: Use expect helpers for pattern values

e45023c

Co-authored-by: logbie <1138960+logbie@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 15, 2026 09:35

Copilot started reviewing on behalf of logbie May 15, 2026 09:36 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

devin-ai-integration Bot reviewed May 15, 2026

View reviewed changes

logbie closed this May 22, 2026

logbie deleted the maintenance-refactor-pattern-expect-17883455864191053605 branch June 19, 2026 04:06

Navigation Menu

Uh oh!

[JULES] Scheduled Maintenance: Pattern Value Refactor - #504

[JULES] Scheduled Maintenance: Pattern Value Refactor#504
logbie wants to merge 1 commit into
mainfrom
maintenance-refactor-pattern-expect-17883455864191053605

logbie commented May 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

google-labs-jules Bot commented May 15, 2026

Uh oh!

coderabbitai Bot commented May 15, 2026 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

logbie commented May 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Verification Checklist

Summary by CodeRabbit

Uh oh!

google-labs-jules Bot commented May 15, 2026

Uh oh!

coderabbitai Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

logbie commented May 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 15, 2026 •

edited

Loading